FYS3150/Project-4
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

First review

Browse Source
This commit is contained in:
Cory Balaton 2023-12-04 16:57:01 +01:00
parent 90047decb4
commit 59a4b70a40
No known key found for this signature in database
GPG Key ID: 3E5FCEBFD80F432B
1 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
review.md Normal file
View File

@ -0,0 +1,92 @@
# PR review
As GitHub does not support adding comments where things haven't changed,
the review will be done here. This is a hassle, but it is the only solution I
have as of now.
## Format
The square brackets are meant to be check boxes, and the numbers are line numbers in a specific file.
## ./latex/ising_model.tex
Nothing
## ./latex/sections/abstract.tex
[ ] 12: variation => variance
[ ] 14: variation => variance
[ ] 16: "We estimate" => "We have estimated" as everything else is in past tense, and the rest of the sentence is in past tense as well.
## ./latex/sections/introduction.tex
[ ] 11: consist => consists. "One of the groups" is singular.
[ ] 12: Is the saturation optional, or will they become saturated when exposed to a magnetic field?
[ ] 26: "as well as algorithms ..." => "as well as the algorithms ..."
[ ] 28: "we conclude ..." => "we will conclude ..."
## ./latex/sections/methods.tex
[ ] 6: consist => consists. "The Ising model" is singular.
[ ] 6: though => thought
[ ] 7: "the length of the lattice ..." => "the length of a lattice ...". We're not talking about a specific lattice.
[ ] 26: remove "will", as we are assuming a 2x2 now and not later in the paper.
[ ] 33: denote => denotes. $\langle k l \rangle$ is singular.
[ ] 34: Change to present tense, as we are considering it in this section and not later in the paper.
[ ] 92: "Values of total energy ..." => "Values of the total energy ..."
[ ] 98: "by number of spins ..." => "by the number of spins ..."
[ ] 162: Why are the equations for heat capacity and susceptibility in different environments?
[ ] 208: transition => transitions. "the Ising model" is singular.
[ ] 209: discontinous => discontinuous
[ ] 211: with => to
[ ] 217: "with an lattice" => "with a lattice"
[ ] 223: Should perhaps create a reference to his paper?
[ ] 224: "using finite lattices ..." => "using the finite lattices'". We are referring to specific lattices and "lattices" should be possessive. I would rewrite the second part to be "using the critical temperature of finite lattices of different sizes and linear regression."
[ ] 230: depend => depends. "the next sample" is singular.
[ ] 239: require => requires. "generating new random states" is singular.
[ ] 240: detaild => detailed
[ ] 241: criterias => criteria. the plural of criterion is criteria.
[ ] 242: Figure => Algorithm, since we can remove the figure environment enclosing the algorithm environment.
[ ] More details are specified in the next comment below.
[ ] 244: A Monte Carlo cycle consists of attempts of flipping a spin, and not a single attempt to flip a spin.
[ ] 261: Instead of having the algorithm inside a figure, you can use the H specifier in the algorithm environment (which you already do). You can read more about it [here](https://tex.stackexchange.com/questions/231191/algorithm-in-revtex4-1). I have already tested that it works, and it makes it so we can actually refer to it as an algorithm and not a figure.
[ ] 284: reach => reaches. "The Markov process" is singular.
[ ] 295: implementation => execution. Implementation is the writing of the code, while the runtime is during execution of the program. I would also say to avoid potentially having the program run endlessly.
[ ] 297: Change of tense. We have used present tense for most of this section, so we should continue with that.
[ ] 300: Lack of if-tests does not hinder parallelization, but it can hinder compiler optimizations.
[ ] 318: used => use. Keep to the present tense for consistency.
[ ] 320: used => use.
[ ] 320: "the Python ..." => "the Python ...". Double space.
[ ] 321: used => use.
[ ] 321: profiler => profiling.
[ ] 321: Remove Scalasca as we only use Score-p now. (Easier to deal with).
## ./latex/sections/results.tex
[ ] 15: Should have a line break to indicate new paragraph.
[ ] 15: It might be relevant, but it's a lot more work. we have all the tools necessary to produce the plots, so it depends on how much work we can do.
[ ] 89: onordered => unordered
[ ] 97: More accurately, we generated 10M samples per temperature point.
[ ] 100: Should be that the program allocated, so that the reader understands that it does the division automatically.
[ ] 101: thread => threads
[ ] 105: We used a profiler. And it's not just for ensuring load balance among threads, it's also for each process, and we use it to see that data transfer is minimal.
[ ] 106: was => were
[ ] 116: deacrese => decrease
[ ] 117: "suggesting the system ..." => "suggesting that the system ...".
[ ] 118: increase => increases. "The system energy" is singular.
[ ] 127: observed => observe.
[ ] 128: "capacity the" => "capacity when the"
[ ] 135: show => shows.
[ ] 136: "Since shape ..." => "Since the shape"
## ./latex/sections/conclusion.tex
[ ] 14: Didn't we arrive at 5000?
[ ] 22: temperature => temperatures
[ ] 24: variation => variance
[ ] 26: variation => variance
## ./latex/sections/appendices.tex
[ ] 95: "The squared energy" => "The squared energy and magnetization functions are then"
[ ] 130: he => the