FYS3150/Project-4
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some new comments

Browse Source
This commit is contained in:
Cory Balaton 2023-12-05 10:43:46 +01:00
parent 5df0a2411b
commit fd934af915
No known key found for this signature in database
GPG Key ID: 3E5FCEBFD80F432B
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
review.md
View File

@ -41,16 +41,16 @@ Nothing
[x] 92: "Values of total energy ..." => "Values of the total energy ..." [x] 92: "Values of total energy ..." => "Values of the total energy ..."
[x] 98: "by number of spins ..." => "by the number of spins ..." [x] 98: "by number of spins ..." => "by the number of spins ..."
[x] 162: Why are the equations for heat capacity and susceptibility in different environments? [x] 162: Why are the equations for heat capacity and susceptibility in different environments?
Well, that is an excellent question! That I do not have an answer to, but I changed it so that both are in equation environment. - janitaws: Well, that is an excellent question! That I do not have an answer to, but I changed it so that both are in equation environment.
[x] 208: transition => transitions. "the Ising model" is singular. [x] 208: transition => transitions. "the Ising model" is singular.
The singular thing is really something I should have a look into! - janitaws: The singular thing is really something I should have a look into!
[x] 209: discontinous => discontinuous [x] 209: discontinous => discontinuous
[x] 211: with => to [x] 211: with => to
[x] 217: "with an lattice" => "with a lattice" [x] 217: "with an lattice" => "with a lattice"
[x] 223: Should perhaps create a reference to his paper? [x] 223: Should perhaps create a reference to his paper?
I agree, I had already added a reference but had forgotten to cite it in the report. I did not include a page number, don't think it is necessary since its what the paper finding? - janitaws: I agree, I had already added a reference but had forgotten to cite it in the report. I did not include a page number, don't think it is necessary since its what the paper finding?
[x] 224: "using finite lattices ..." => "using the finite lattices'". We are referring to specific lattices and "lattices" should be possessive. I would rewrite the second part to be "using the critical temperature of finite lattices of different sizes and linear regression." [x] 224: "using finite lattices ..." => "using the finite lattices'". We are referring to specific lattices and "lattices" should be possessive. I would rewrite the second part to be "using the critical temperature of finite lattices of different sizes and linear regression."
I agree, it does make more sense - janitaws: I agree, it does make more sense
[x] 230: depend => depends. "the next sample" is singular. [x] 230: depend => depends. "the next sample" is singular.
[x] 239: require => requires. "generating new random states" is singular. [x] 239: require => requires. "generating new random states" is singular.
[x] 240: detaild => detailed [x] 240: detaild => detailed
@ -104,6 +104,7 @@ I agree!
- janitaws: So instead of "We ran a profiler" it should be "We used a profiler"? Could you suggest a way of formulating the sentence so that the info is correct? - janitaws: So instead of "We ran a profiler" it should be "We used a profiler"? Could you suggest a way of formulating the sentence so that the info is correct?
- coryab: Yes to the first point. "To check if the parallelization was optimal, we used a profiler, which found that the program was efficient. The thing that scored slightly less was the MPI load balance, which is most likely because the master process gathered all data using blocking communication, which made the other processes wait, in addition to having one process work more." - coryab: Yes to the first point. "To check if the parallelization was optimal, we used a profiler, which found that the program was efficient. The thing that scored slightly less was the MPI load balance, which is most likely because the master process gathered all data using blocking communication, which made the other processes wait, in addition to having one process work more."
- janitaws: If we simply state that the program was efficient we should include some sort of evidence supporting the statement, since the view of efficiency is subjective. Maybe we could include percentage here to support it, the profile gave a number right? - janitaws: If we simply state that the program was efficient we should include some sort of evidence supporting the statement, since the view of efficiency is subjective. Maybe we could include percentage here to support it, the profile gave a number right?
- coryab: I added an image called profiling.pdf that has all of the numbers necessary, so we can either add the image, or the results.
[ ] 106: was => were [ ] 106: was => were
- janitaws: My previous comment might make this unnecessary? - janitaws: My previous comment might make this unnecessary?
- coryab: If you use my suggestion, then this can be checked off at the same time. - coryab: If you use my suggestion, then this can be checked off at the same time.